Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a couple of remaining small fix #419

Merged
merged 6 commits into from
Mar 2, 2021
Merged

a couple of remaining small fix #419

merged 6 commits into from
Mar 2, 2021

Conversation

heimengqi
Copy link
Contributor

This PR will fix two things:

  1. fix Creating copies of pred and pred_stderr in inference results #402
  2. fix the remaining shap issue, when parse const_marginal_effect, original feature names is not correctly passed through

@heimengqi heimengqi mentioned this pull request Feb 24, 2021
Closed
@heimengqi heimengqi linked an issue Feb 25, 2021 that may be closed by this pull request
DRLearner's score is wrong when final model returns an array instead of a vector #420
Closed
kbattocchi
kbattocchi requested changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just needs tests for the fixes to show that both issues no longer repro.

econml/_shap.py Show resolved Hide resolved
econml/_shap.py Show resolved Hide resolved
econml/dr/_drlearner.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Show resolved Hide resolved
@heimengqi heimengqi mentioned this pull request Mar 1, 2021
Merged
kbattocchi
kbattocchi approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please clean up decorator formatting.

econml/tests/test_drlearner.py Outdated Show resolved Hide resolved
econml/tests/test_drlearner.py Outdated Show resolved Hide resolved
econml/tests/test_drlearner.py Outdated Show resolved Hide resolved
econml/tests/test_drlearner.py Outdated Show resolved Hide resolved
@heimengqi heimengqi merged commit 5e31584 into master Mar 2, 2021
@heimengqi heimengqi deleted the mehei/bugfix branch March 2, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@heimengqi @kbattocchi