Suggest numpy testing module on pytest approx docs #8615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Apr 30, 2021
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @tarcisiofischer!
Small suggestion on the changelog, other than that LGTM!
Contributor
Author
|
Is there any way I can see the generated docs before merging? I didn't check the produced HTML file 🤔 |
Member
There's a readthedocs build that you can see the generated HTML:
|
Contributor
Author
|
LGTM. Ready to merge. |
nicoddemus
approved these changes
May 3, 2021
Member
|
FYI I've fixed the changelog and moved the suggestion to a "Note" box at the end of the text, which I believe it is better. 👍 |
Member
|
Note: we should squash this IMHO. |
Zac-HD
reviewed
May 4, 2021
Co-authored-by: Zac Hatfield-Dodds <[email protected]>
Zac-HD
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8337
I was in doubt if this change needs a
changelog, and, if it needs, if I should addtrivialordocs(because it is both, IMO)