Skip to content

Conversation

@symonk
Copy link
Member

@symonk symonk commented Oct 27, 2021

Some minor tweaks to the terminal.py module, namely:

  • Removal of unused args for mywriter and _locationline (tags and lineno respectively), neither appear used
  • Some extra typing in places
  • Change getreports to use a list comp
  • Simplify _getfailureheadline

edit: Other merged PRs have done some of the same work here, so its quite miniscule now

@symonk
Copy link
Member Author

symonk commented Nov 2, 2021

Thanks @bluetech between some reverts & the other PR outlined this ended up being tiny, sorry to take your time for such trivial changes in the end. Appreciate it as always (will make sure to squash if you feel the list comp change is worth while!)

@symonk symonk merged commit 7037a58 into pytest-dev:main Nov 6, 2021
@symonk symonk deleted the minor-tidyup-of-terminal-py branch November 6, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants