Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for decorated overloads #15898

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Basic support for decorated overloads #15898

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70666c9
Support decorated overloads
ilevkivskyi Aug 17, 2023
397334f
Fix typo
ilevkivskyi Aug 17, 2023
c6560f4
Reduce noise on broken overloads
ilevkivskyi Aug 17, 2023
c34521d
Try more principled way to detect decorated overloads
ilevkivskyi Aug 17, 2023
a1480e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 17, 2023
8b3c538
Refactor code to speed thing up
ilevkivskyi Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Aug 17, 2023
commit a1480e940f1b073cf8ffe9ed152ead08318cba85
3 changes: 2 additions & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,8 @@ def analyze_overloaded_func_def(self, defn: OverloadedFuncDef) -> None:
if types and not any(
# If some overload items are decorated with other decorators, then
# the overload type will be determined during type checking.
isinstance(it, Decorator) and len(it.decorators) > 1 for it in defn.items
isinstance(it, Decorator) and len(it.decorators) > 1
for it in defn.items
):
# TODO: should we enforce decorated overloads consistency somehow?
# Some existing code uses both styles:
Expand Down