Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #75

Closed
wants to merge 2 commits into from
Closed

Update README.md #75

wants to merge 2 commits into from

Conversation

mart1435
Copy link

@mart1435 mart1435 commented Oct 1, 2020

Added Side-channel attacks in the crypto section !

Added Side-channel attacks in the crypto section !
@qazbnm456
Copy link
Owner

Hi @mart1435, thanks for your contribution. There're a few things that need you to check:

  1. We don't need the "Scroll To Text Fragment" part in the URL since the article is all about the side-channel attacks.
  2. Please change the rear part of your text. It should be "Written by [...](...)" to give the credit to the original author.
  3. Could you update other README files at the same time so as to keep them aligned?

Thank you. :)

@mart1435
Copy link
Author

mart1435 commented Oct 3, 2020

I think it's done, I hope i did good :D

@qazbnm456
Copy link
Owner

Ah, could you update these README files at once in a sole PR? Thanks!

@qazbnm456
Copy link
Owner

Close per 0643a30.

@qazbnm456 qazbnm456 closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants