Skip to content

Conversation

@sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jan 24, 2020

In an earlier iteration I had also UNPACKed some Text fields. But then I noticed that we don't actually look at them so often, so I assumed it's not worth it.

Context: #121

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jan 24, 2020

I wonder whether this is a breaking change with regards to the PVP?

If any entity was removed, or the types of any entities or the definitions of datatypes or classes were changed, or orphan instances were added or any instances were removed, then the new A.B MUST be greater than the previous A.B.

Do these changes constitute proper changes to "the definitions of datatypes"?

The derived Generic instances change which I guess is sufficient grounds for a major bump…

We don't actually scrutinize these so often.
@sjakobi sjakobi added the PVP: major Requires a major version bump label Feb 8, 2020
@quchen
Copy link
Owner

quchen commented Mar 6, 2020

Strictly speaking, this is a major bump. On the plus side, many changes in prettyprinter warrant major bumps, so this can be packed with another major change, no need for its own release.

@sjakobi sjakobi merged commit 430363f into master Jun 30, 2020
@sjakobi sjakobi deleted the unpack-fields branch June 30, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Performance PVP: major Requires a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants