Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple templates validation (#38, #54) #11

Merged
merged 10 commits into from
Apr 14, 2020

Conversation

quintush
Copy link
Owner

No description provided.

@quintush quintush changed the title Feature/multiple templates validation Feature/multiple templates validation (#38, #54) Apr 14, 2020
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #11 into master will increase coverage by 2.99%.
The diff coverage is 99.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   78.50%   81.50%   +2.99%     
==========================================
  Files          27       27              
  Lines        1563     1670     +107     
==========================================
+ Hits         1227     1361     +134     
+ Misses        231      220      -11     
+ Partials      105       89      -16     
Impacted Files Coverage Δ
unittest/assertion.go 76.39% <96.43%> (+10.93%) ⬆️
unittest/test_job.go 78.95% <100.00%> (+1.67%) ⬆️
unittest/test_suite.go 77.39% <100.00%> (ø)
unittest/validators/common.go 100.00% <100.00%> (+7.41%) ⬆️
unittest/validators/contains_validator.go 100.00% <100.00%> (+10.53%) ⬆️
unittest/validators/equal_validator.go 100.00% <100.00%> (+5.88%) ⬆️
unittest/validators/has_document_validator.go 100.00% <100.00%> (ø)
unittest/validators/is_apiversion_validator.go 100.00% <100.00%> (+13.33%) ⬆️
unittest/validators/is_empty_validator.go 100.00% <100.00%> (+13.33%) ⬆️
unittest/validators/is_kind_validator.go 100.00% <100.00%> (+13.33%) ⬆️
... and 6 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 55 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@quintush quintush merged commit efb7a1c into master Apr 14, 2020
quintush added a commit that referenced this pull request Apr 14, 2020
* Add IsSubsetValidator, including test verification (#6).

* Add raw assertions for NOTES.txt (#11), including tests.

* Fix resolving and running templates in subfolders, including test verification. (#44)

* Add Counter to contains assertion to validate the number of times a value appears in an array. (#52)

* Add Any (boolean) to contains assertion to ignore the other values to be validated within an array. Added testverification and updated documentation. (#74)

* Update Makefile with unittest, add additional logging when a test fails in test_runner.

* Uniform Raw output. Update snapshots with correct line endings.

* Fix matchSnapshotRaw tests and improve errorhandling. Testresult fails with error when loading is failed, instead of ignoring the handling.

* Add buffer when a testrunner test failes.

* Add Counter to contains assertion to validate the number of times a value appears in an array. (#52)

* Add IsSubsetValidator, including test verification (#6).

* Improve testabillity and lower code duplication.
@quintush quintush deleted the feature/multipleTemplatesValidation branch April 14, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant