Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add descriptions to the onehot_ function #122

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

4may
Copy link
Contributor

@4may 4may commented Apr 21, 2020

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@4may 4may closed this May 5, 2020
@rasbt rasbt reopened this May 5, 2020
@rasbt
Copy link
Owner

rasbt commented May 5, 2020

Sorry, didn't see this PR earlier. Let me have a look at it

@rasbt
Copy link
Owner

rasbt commented May 5, 2020

Actually, looking at it, this PR looks very useful, adding the missing docstring for the _onehot method. May I ask why you closed it?

@4may
Copy link
Contributor Author

4may commented May 6, 2020

Thank you for your reviewing. I’m sorry, I misunderstood that my pr was not useful for you.
If there are no problem in my pr, please merge it at your convenience :)

@4may
Copy link
Contributor Author

4may commented May 6, 2020

I finally had read your book yesterday. It took a month.
It was challenging for me, since I am Japanese and not good at English.
But it was so exciting experience and I’ve learned a lot thanks to your book :)
Thank you!

@rasbt
Copy link
Owner

rasbt commented May 7, 2020

Sorry about causing this misunderstanding. It's been a very busy semester and I didn't see it earlier. In any case, your contribution is useful indeed, and thanks for the PR. I am also happy to hear that you found the book useful!

@rasbt rasbt merged commit 54d14eb into rasbt:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants