Add edit pencil icon (✎) on hover for labels when edit mode is on #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CloudNode (svgGen.tsx): Wrapped text in a group with editable-label class and added pencil icon that appears on hover when in edit mode - Tree component (Tree.tsx): Added pencil icon next to each non-intermediate node label when edit mode is enabled, with CSS hover effect to show icon - Both implementations use CSS opacity transition for smooth appearance
- Pencil icons are now always rendered in DOM
- Visibility controlled purely by CSS using svg.edit-mode class
- CSS rule: svg.edit-mode .label:hover .edit-pencil { opacity: 1 }
- Removed conditional rendering and JS-based opacity control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When edit mode is enabled, all diagram labels now show a pencil icon (✎) when hovering over them. This provides a visual indicator that the label is editable.
Changes
CloudNode Component (
src/svgGen.tsx)<g>group witheditable-labelclass when in edit modeTree Component (
src/Tree.tsx)editable-labelclass to nodes in edit modeTechnical Details
Testing
@raymyers can click here to continue refining the PR