Simplified for loop for some image manipulation functions#3712
Merged
raysan5 merged 1 commit intoraysan5:masterfrom Jan 6, 2024
Merged
Simplified for loop for some image manipulation functions#3712raysan5 merged 1 commit intoraysan5:masterfrom
raysan5 merged 1 commit intoraysan5:masterfrom
Conversation
Owner
|
@Minnowo Nice improvement! Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image manipulation functions
ImageColorInvert,ImageColorBrightness,ImageColorReplace, andImageColorTintall used a nested for loop with some math to index the 1d array of pixels.These loops could be simplified to a single loop with a counter. I think this is not only more readable, but it has also shown some slight speed increases for very large images. My numbers below using the diff of time.h's clock function for a 7096 x 10031 image:
before:
after: