Skip to content

Conversation

@mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Feb 8, 2024

@vercel
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 8, 2024 2:02am

@github-actions
Copy link

github-actions bot commented Feb 8, 2024

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.86 KB (🟡 +46 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.75 KB (🟡 +2 B) 183.61 KB
/500 79.75 KB (🟡 +2 B) 183.6 KB
/[[...markdownPath]] 81.44 KB (🟡 +2 B) 185.3 KB
/errors 79.93 KB (🟡 +2 B) 183.79 KB
/errors/[errorCode] 79.91 KB (🟡 +2 B) 183.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Comment on lines +174 to +192
import { useState, startTransition, useOptimistic } from "react";
import { addCount } from "./api";

export default function Form() {
const [pending, setPending] = useState(false);
const [count, setCount] = useState(0);
const [optimisticCount, optimisticIncreaseCount] = useOptimistic(
count,
(state) => state + 1
);
function handleSubmit(event) {
event.preventDefault();
setPending(true);
startTransition(async () => {
optimisticIncreaseCount();
const updatedCount = await addCount(count);
setCount(updatedCount);
setPending(false);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { useState, startTransition, useOptimistic } from "react";
import { addCount } from "./api";
export default function Form() {
const [pending, setPending] = useState(false);
const [count, setCount] = useState(0);
const [optimisticCount, optimisticIncreaseCount] = useOptimistic(
count,
(state) => state + 1
);
function handleSubmit(event) {
event.preventDefault();
setPending(true);
startTransition(async () => {
optimisticIncreaseCount();
const updatedCount = await addCount(count);
setCount(updatedCount);
setPending(false);
});
import { useTransition, useOptimistic } from "react";
import { addCount } from "./api";
export default function Form() {
const [pending, startTransition] = useTransition();
const [count, setCount] = useState(0);
const [optimisticCount, optimisticIncreaseCount] = useOptimistic(
count,
(state) => state + 1
);
function handleSubmit(event) {
event.preventDefault();
startTransition(async () => {
optimisticIncreaseCount();
const updatedCount = await addCount(count);
setCount(updatedCount);
});

@eps1lon
Copy link
Member

eps1lon commented Feb 8, 2024

Do we also have a similar pitfall for useContext? I remember one or two cases where people also didn't know they had to call useContext from within the tree that a Context wraps.

Maybe it makes sense teach useFormStatus as a kind of useContext where the nearest form is the provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants