feat: variables and glossary #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishaprile
reviewed
Apr 15, 2024
Contributor
trishaprile
left a comment
There was a problem hiding this comment.
niceee
one behavior I noticed is that << breaks the page
example/Form.tsx
Outdated
Comment on lines
24
to
28
| console.log(params); | ||
| return params; | ||
| }); | ||
|
|
||
| navigate(event.target.value); | ||
| console.log(event.target.value); |
Comment on lines
+2
to
+16
| title: 'Variable Tests' | ||
| category: 5fdf9fc9c2a7ef443e937315 | ||
| hidden: true | ||
| --- | ||
| <<defvar>> and `<<defvar>>` and: | ||
|
|
||
| <Variable variable="defvar" /> and `<Variable variable="defvar" />` and: | ||
|
|
||
| ``` | ||
| <<defvar>> | ||
| <Variable variable="defvar" /> | ||
| ``` | ||
|
|
||
| and | ||
|
|
||
| ```js | ||
| const xyz = "<<defvar>>"; | ||
| const xyz = "<Variable variable="defvar" />"; |
Contributor
There was a problem hiding this comment.
should we also add an example for <GlossaryItem /> to this?
Contributor
Author
Yea, not sure what to do with parsing errors yet. I do not want to support the old syntax since it causes a parsing error, that just sounds like a bad time. |
Contributor
Author
|
I'm going to merge this, but if you have any other reviews please let me know! |
Contributor
|
This PR was released!🚀 Changes included in v6.75.0-beta.27 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Supports Variables and GlossaryItems!
Ok, so this PR only has a small 🤏 code change for those components. We just have to format the correct jsx in the editor for this to work, I think.
This PR does
flavored-*to*yamlfrom the top of the doc🧬 QA & Testing