Skip to content

feat: readme-variable #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kellyjosephprice merged 7 commits into from
Jun 27, 2024
Merged

feat: readme-variable #913

kellyjosephprice merged 7 commits into from
Jun 27, 2024

Conversation

@kellyjosephprice
Copy link
Contributor

@kellyjosephprice kellyjosephprice commented Jun 21, 2024 •
edited
Loading

PR App RM-9917

🧰 Changes

Adds readme-variable to the mdast for the editor to consume

I found myself transforming mdx nodes in the editor and decided I should stick my existing convetion to do that in the library.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta June 21, 2024 17:56
@kellyjosephprice kellyjosephprice marked this pull request as ready for review June 21, 2024 23:26
jennspencer
jennspencer approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good?

@kellyjosephprice
Copy link
Contributor Author

kellyjosephprice commented Jun 27, 2024

looks good?

I'll take it!

@kellyjosephprice kellyjosephprice merged commit e3c4a5e into beta Jun 27, 2024
@kellyjosephprice kellyjosephprice deleted the coerce-vars branch June 27, 2024 02:20
rafegoldberg pushed a commit that referenced this pull request Jun 27, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.63 🦉
e680bd8 
## Version 6.75.0-beta.63

### ✨ New & Improved

* readme-variable ([#913](#913)) ([e3c4a5e](e3c4a5e))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

rafegoldberg commented Jun 27, 2024

This PR was released!

🚀 Changes included in v6.75.0-beta.63

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

@trishaprile trishaprile Awaiting requested review from trishaprile

1 more reviewer

@jennspencer jennspencer jennspencer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kellyjosephprice @rafegoldberg @jennspencer