Add redis subchart#114
Add redis subchart#114JamieMagee merged 13 commits intorenovatebot:masterfrom ArmaanT:feat/113-redis
Conversation
viceice
left a comment
There was a problem hiding this comment.
Do we need to commit the subchart? I think this can be removed from repo.
|
It needs a github workflow change to add the helm repo for bitnami charts |
I think it needs to be committed. If I delete the directory and try to helm install, I get the following error: Edit: Actually, I think it may be possible to remove |
|
I was just about to post your edit 😅 We need to add helm repo add bitnami https://charts.bitnami.com/bitnami
helm dependency build |
viceice
left a comment
There was a problem hiding this comment.
Can you please try @JamieMagee plan.
|
Okay, this should be ready for review now. I've updated the original PR description with an explanation of my changes. I haven't tested the release workflow changes. However, it uses very similar logic to kubeval, so I'm reasonably confident it will work. |
viceice
left a comment
There was a problem hiding this comment.
@JamieMagee what do you think?
|
Overall looks good. I just have 2 questions:
|
Co-authored-by: Jamie Magee <JamieMagee@users.noreply.github.com>
|
|
Thanks for the answers. I had a look into 2 myself, and it appears that repositories are not added automatically due to security concerns. LGTM |
This PR:
ctto lint and run tests onCloses #113