Rename KSCrash types, functions and files to RollbarCrash to avoid collisions#301
Merged
matux merged 4 commits intokscrash_integrationfrom Jul 6, 2023
Merged
Rename KSCrash types, functions and files to RollbarCrash to avoid collisions#301matux merged 4 commits intokscrash_integrationfrom
matux merged 4 commits intokscrash_integrationfrom
Conversation
|
This pull request has been linked to Shortcut Story #127332: Unable to integrate Apple SDK to Frameworks. |
cyrusradfar
approved these changes
Jul 6, 2023
cyrusradfar
left a comment
There was a problem hiding this comment.
Refactor and rename will make things clearer and allow us to more configurability to a stale library. Thanks, LGTM.
Collaborator
Author
|
This will fix the name ambiguity linking issues and potential collisions, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
KSCrash license is still in every source as mandated by it.
This PR is being merged into the
kscrash_integrationfeature branch, not onmaster.Renames help us avoid naming collisions if someone decides to use
KSCrashalong our library, to avoid confusion and signal our version diverges from the original library.This also helps ease errors that begun due to Xcode 14.3 updates, more info. See also: swiftlang/swift#64669.
Type of change
Related issues
Checklists
Development
Code review