Conversation
Previously, struct field idents would be written directly into the output buffer. Now, the write_identifier method is used to apply the usual logic and serialize as raw ident if characters are found to not be a valid regular identifier. Fixes #322
Member
Author
|
r? @kvark |
Member
Author
|
I think we haven't had a breaking change, but I'm not actually sure. Should we do a 0.7 release instead? |
kvark
reviewed
Oct 21, 2021
Collaborator
kvark
left a comment
There was a problem hiding this comment.
Just one note, otherwise looks great!
torkleyy
added a commit
that referenced
this pull request
Oct 22, 2021
Backport (#323): Serialize struct idents with Serializer::write_identifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, struct field idents would be written directly into the
output buffer.
Now, the write_identifier method is used to apply the usual logic
and serialize as raw ident if characters are found to not be a valid
regular identifier.
Fixes #322