Bump MSRV to 1.57.0 and base64 to 0.20#431
Conversation
Codecov ReportBase: 86.88% // Head: 86.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 59 59
Lines 7267 7267
=======================================
Hits 6314 6314
Misses 953 953
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Will need to be followed up by a migration to 0.21 (#432) |
torkleyy
left a comment
There was a problem hiding this comment.
Looks good, I only wonder if base64 is good to have baked into RON, given that you could easily do it yourself with serde attributes.
Removing it would be a rather unpleasent breaking change for anyone using it however... Any thoughts?
You can merge it as-is, this is just what came to my mind right now ^^
Do you mean users could hardcode how they want to (de)serialise their bytes? That's definitely true (and what I do in a personal use case), but we'd still need to figure out how we want to encode bytes in the ron format. Do you have a suggestion for what would be a good alternative?
That's my concern too. Anyone using ron with byte-encoded data would suddenly no longer be able to parse their config files. Since that would be a breaking change in the format and not in the crate, I think it would be difficult to justify outside of a major (major) version bump.
Thanks :) |
Supersedes #430
If we want to upgrade to
base640.20, we need to bump our MSRV to 1.57 as well.CHANGELOG.md