Merged
Conversation
juntyr
reviewed
Jun 28, 2023
juntyr
reviewed
Jun 28, 2023
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 85.65% 85.29% -0.37%
==========================================
Files 61 61
Lines 7760 7793 +33
==========================================
Hits 6647 6647
- Misses 1113 1146 +33
☔ View full report in Codecov by Sentry. |
juntyr
requested changes
Jun 28, 2023
Member
juntyr
left a comment
There was a problem hiding this comment.
LGTM with the suggested changes applied.
Thank you @marcospb19 for your contribution!
b4db797 to
2b247a6
Compare
Contributor
Author
|
Force-pushed accordingly, thanks for the great review :D . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md