[RF] Translated 2 RooStats tutorials to PyROOT #13558
Conversation
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
@guitargeek any updates on this? |
For his translations of RooStats tutorials
* Get rid of checks if files or objects in the file were found. It's ROOTs responsability to error out nicely if something is not found, not the responsability of the tutorials * Use f-formatting in Python to be more concise * Use Python iteration patters * Use pythonic `len()` instead of `GetSize()` * Use native Python string instead of `TString` * In Python, one can retrieve objects in the `RooWorkspace with `workspace[obj_name]` independent of the type, which is preferred because it's more Pythonic
98420b8 to
8f0611e
Compare
There was a problem hiding this comment.
Excellent work, thanks for taking the initiative and opening the PR 👍👍
Sorry for the late reply. We first had to focus on getting ROOT 6.30 ready, which will be released any day.
I have added a commit with some changes to make the Python versions more Pythonic (see more detail in the commit logs). I hope this helps you also to learn writing more Pythonic PyROOT code in the future (hopefully also in more contributions like this one 🙂 )
I already pushed the changes to your branch, when the CI is green I will merge this.
I also added you to the list of contributors, so that you will appear in the release notes of ROOT 6.32.
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
This Pull request:
Changes or fixes:
Adds StandardProfileInspectorDemo.py and StandardProfileLikelihoodDemo.py, from StandardProfileInspectorDemo.C and StandardProfileLikelihoodDemo.C. Also fixes a typo in StandardProfileInspectorDemo.C and a comment in TMVA_Higgs_Classification.py.
Checklist:
black --line-length=120 <tutorial file>.py)This PR contributes to #8758