Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry tutorials translated into Python. #15573

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PPaye
Copy link
Contributor

@PPaye PPaye commented May 21, 2024

This Pull request:

Adds a Complete translation of the Geometry-Tutorials into python.

Changes or fixes:

It runs, it re-reruns, and it gets out of IPython without crashing memory.
The Root-Objects have been cautiously removed once they have been created by pyroot, this helps to run the scripts again-and-again without crashing memory, since ROOT hasn't the ownership of the Objects anymore.
Enjoy the pygeom tutorials, if so.

Checklist:

  • [ yes] tested changes locally
  • [ yes] updated the docs (if necessary)
  • [ yes] synchronized forked with master(latest-stable)

This PR fixes #

It doesn't fix anything but adds alternatives approach to use pyroot with
the Geometry Package.

@PPaye PPaye requested a review from couet as a code owner May 21, 2024 02:16
@dpiparo dpiparo requested a review from agheata May 23, 2024 12:58
Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data files should not be included in the tutorials/pygeom directory, but used directly from tutorials/geom

tutorials/pygeom/files/cms.root Outdated Show resolved Hide resolved
tutorials/pygeom/files/cms.root.ROOT.cachefile Outdated Show resolved Hide resolved
tutorials/pygeom/gdml/opticalsurfaces.gdml Outdated Show resolved Hide resolved
tutorials/pygeom/gdml/tmp.gdml Outdated Show resolved Hide resolved
tutorials/pygeom/gdml/tmp.root Outdated Show resolved Hide resolved
tutorials/pygeom/teddy.obj Outdated Show resolved Hide resolved
Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work! I've made some comments, many repetitive because I tested each script.

tutorials/pygeom/building.py Outdated Show resolved Hide resolved
tutorials/pygeom/cheongwadae.py Outdated Show resolved Hide resolved
tutorials/pygeom/geodemo.py Outdated Show resolved Hide resolved
tutorials/pygeom/geomAlice.py Outdated Show resolved Hide resolved
tutorials/pygeom/geomAlice_itsv.py Outdated Show resolved Hide resolved
tutorials/pygeom/station1.py Outdated Show resolved Hide resolved
tutorials/pygeom/station2.py Outdated Show resolved Hide resolved
tutorials/pygeom/tank.py Outdated Show resolved Hide resolved
tutorials/pygeom/tessellatedNav.py Outdated Show resolved Hide resolved
tutorials/pygeom/visualizeWavefrontObj.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 23, 2024

Test Results

    12 files      12 suites   2d 18h 45m 2s ⏱️
 2 676 tests  2 664 ✅ 0 💤  12 ❌
30 385 runs  30 283 ✅ 0 💤 102 ❌

For more details on these failures, see this check.

Results for commit be1ff22.

♻️ This comment has been updated with latest results.

Piter Amador Paye Mamani added 2 commits May 24, 2024 17:46
@PPaye PPaye marked this pull request as draft November 5, 2024 02:42
@PPaye PPaye marked this pull request as ready for review November 5, 2024 02:52
@couet couet removed their request for review December 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants