-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry tutorials translated into Python. #15573
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data files should not be included in the tutorials/pygeom directory
, but used directly from tutorials/geom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work! I've made some comments, many repetitive because I tested each script.
Test Results 12 files 12 suites 2d 18h 45m 2s ⏱️ For more details on these failures, see this check. Results for commit be1ff22. ♻️ This comment has been updated with latest results. |
…rom A.Gheata have been done except the ogl option.
…ials Update branch to root-6.32
This Pull request:
Adds a Complete translation of the Geometry-Tutorials into python.
Changes or fixes:
It runs, it re-reruns, and it gets out of IPython without crashing memory.
The Root-Objects have been cautiously removed once they have been created by pyroot, this helps to run the scripts again-and-again without crashing memory, since ROOT hasn't the ownership of the Objects anymore.
Enjoy the pygeom tutorials, if so.
Checklist:
This PR fixes #
It doesn't fix anything but adds alternatives approach to use pyroot with
the Geometry Package.