Update IncrementalCUDADeviceCompiler.cpp - change string comparison to exact match for "-include" #16196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the loop to use exact string comparison
(s == "-include")
instead of checking if the string starts with "-include"(s.find("-include") == 0)
to ensure only exact matches are considered.Explanation
(s.find("-include")
: Addss
toargv
ifs
starts with"-include"
.(s == "-include")
: Addss
toargv
only ifs
is exactly"-include"
.The first snippet is more inclusive, as it will match any string that begins with
"-include"
, such as"-include-pch"
or something else starting with"-include"
, while the second snippet will only match the exact string"-include"
.