Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF][HS3] Minor fixes #16938

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[RF][HS3] Minor fixes #16938

wants to merge 4 commits into from

Conversation

cburgard
Copy link
Contributor

@cburgard cburgard commented Nov 14, 2024 •
edited
Loading

This Pull request:

Contains several bugfixes related to HS3:

  • Performs code cleanup on some sections of the HS3 HistFactory implementation
  • Improves constraint handling for ShapeFactor-type modifiers
  • Enables proper tracking of Global Observables in import and export of HS3 JSON files

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@github-actions GitHub Actions
Copy link

Test Results

    13 files      13 suites   3d 13h 4m 57s ⏱️
 2 630 tests  2 628 ✅ 0 💤  2 ❌
33 842 runs  33 828 ✅ 0 💤 14 ❌

For more details on these failures, see this check.

Results for commit 6aba406.

@guitargeek guitargeek force-pushed the name-checking-improvements branch from 6aba406 to 93de8ae Compare November 14, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@guitargeek guitargeek Awaiting requested review from guitargeek guitargeek is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@guitargeek guitargeek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cburgard @guitargeek