[RF] Fix some design issues with the RooTreeDataStore #17165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 4d 4h 12m 5s ⏱️ For more details on these failures, see this check. Results for commit b3554e8. ♻️ This comment has been updated with latest results. |
1. The RooAbsDataStore has a virtual function `tree()` which is not meaningful for a general data store. This function should be removed. 2. The RooTreeDataStore has one `const` version on `tree()` and one non-const version. One returns a pointer and the other a reference, which is very confusing. 3. The RooTreeDataStore has some methods that just forward to the underlying TTree, but they were not used. Changes to the data store classes can be made without impacting users because they are implementation details of the RooFit dataset classes.
Using this function is introducing memory leaks too easily if used wrong, because it returns a `RooArgsSet *` that needs to be deleted by the caller without documenting this. This commit suggests to simply remove this function, after all one could just call `addColumn()` in a loop and be safe.
c38adf4 to
b3554e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RooAbsDataStore has a virtual function
tree()which is not meaningful for a general data store. This function should be removed.The RooTreeDataStore has one
constversion ontree()and one non-const version. One returns a pointer and the other a reference, which is very confusing.The RooTreeDataStore has some methods that just forward to the underlying TTree, but they were not used.
Changes to the data store classes can be made without impacting users because they are implementation details of the RooFit dataset classes.