[RF] extend RooBinIntegrator to N-dimensions #17247
Open
+36
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://its.cern.ch/jira/browse/ROOT-9996 Currently it failed silently for more than 3 dimensions
Test Results 18 files 18 suites 4d 12h 26m 33s ⏱️ Results for commit 655d1b2. ♻️ This comment has been updated with latest results. |
guitargeek
reviewed
Dec 12, 2024
guitargeek
previously requested changes
Dec 12, 2024
There was a problem hiding this comment.
Thank you very much for the initiative, this is great! Please refactor the code a bit to not not introduce too many manual memory allocations by constructing std::vector. These are very expensive in performance. I guess just one allocation of some working memory that is passed around in the recursive function should work, if it can't be avoided entirely.
guitargeek
reviewed
Dec 12, 2024
as suggested by guitargeek
Thanks for the suggestions. Done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-9996
Currently it failed silently for more than 3 dimensions
Checklist: