[v634][RF] Backports of recent fixes and improvements #17370
Merged
+83
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're not calling `ClearProxiedObjects()` anymore anyway, we don't need the hack to avoid it.
The RooCrystalBall class didn't have getters to its parameters yet, which we generally need for all commonly-used PDFs for model inspection and IO (other than IO with ROOT files).
Support also `createNLL` in case of partially-extended simultaneous fits with the new default CPU backend (and hence also "codegen"). This problem was reported by @gartrog in private communication. Add also a corresponding test.
This is useful to avoid manual casting of the return value to `RooArgSet *`. Other methods, like `selectByName` already do this.
It was forgotten to call `delete` on the return value of `selectByAttrib`. Wrapping the return value in a `std::unique_ptr` fixes the problem.
a53dc49
into
root-project:v6-34-00-patches
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of recent fixes and improvements in RooFit to the 6.34 branch.