[CMake] Fix a few small issues #17425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hageboeck
commented
Jan 14, 2025
- Add a few missing labels to unittests
- Add warnings or errors when ROOT is configured in a way that cannot work (e.g. asking for webdisplay without http)
With http disabled, webdisplay encounters an error during build time. Here, the error is pushed to cmake configure time.
Previously, no specific component was required, so even though OpenSSL might be found in the system, the OpenSSL::SSL target might have been missing.
Although they run python, pyunittests were not labelled as python tests.
When switching off http, and switching webgui on, webgui disables itself. Instead emitting a helpful warning, a message that can easily be missed was printed. Since the user might have intended to switch on the webgui, ROOT should warn before switching it off.
pcanal
reviewed
Jan 14, 2025
| @@ -871,10 +871,12 @@ if(ROOT_pyroot_FOUND) | |||
| analysis/dataframe/df032_RDFFromNumpy.py | |||
| math/fit/combinedFit.py | |||
| math/fit/multifit.py | |||
| math/fit/NumericalMinimization.py | |||
There was a problem hiding this comment.
Unrelated to this PR per se. Do you know why we use FILE(GLOB .... here instead of just a hard coded list?
There was a problem hiding this comment.
I guess the strategy is copied from a different location, and the advantage of GLOB is obviously the support for expressions like:
math/fit/*_numpy.py
There was a problem hiding this comment.
Here is an example:
Line 751 in d72ed64
I guess people just use globs for all the vetos, so you can switch between list and globs.
Test Results 18 files 18 suites 3d 20h 8m 29s ⏱️ Results for commit 86155b7. ♻️ This comment has been updated with latest results. |
… installed. Instead of checking at test time whether the python packages required by a tutorial are installed, the check is now done at configure time. If a required package is not installed, the test is marked as disabled, so it shows in CTest, but doesn't generate a failure. This should help the lcg people, who needed to veto these tests manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.