[rbrowser] share single connection between all widgets #17450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like TWebCanvas can be embed into RBrowser, but at the same time RFitPanel can be embed into TWebCanvas Correctly master handle connection close - one need to inform all embed widgets that connection is closing
Use special call to reuse existing browser connection for the canvas. Improves startup time, also let reuse same websocket for many canvases
Allows to embed RCanvas into RBrowser
Instead direct connection to web window just create channel and provide id to the server
Support proper embeding of canvas and geometry widgets into RBrowser Serveral other fixes
Test Results 18 files 18 suites 4d 5h 3m 10s ⏱️ For more details on these failures, see this check. Results for commit b9a0769. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now each widget as
TWebCanvasorRGeomViewerwas establishing separate websocket connection with the server. This consumes extra resources and takes long time to reload such widget.Now
RWebWindowembedding will be used. For that one need to provide access toRWebWindowfor each of concerned widgets.Update JSROOT which also has to support such new feature