[RF] Support non-uniform binnings in codegen to enable AD for non-uniform template fits #17452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the code generation also for template histograms with non-uniform binning, to enable automatic differentiation for template fits with non-uniform bins. This was requested both by CMS and ATLAS users, because they use non-uniform binnings in their Higgs combinations.
If RooFit is build standalone, the interpreter doesn't automatically include its header files. That's why we need to manually include the header with the implementation details of the code generation. Otherwise, the dispatching to the translate functions doesn't work in RooFit standalone.
Test Results 18 files 18 suites 3d 23h 37m 33s ⏱️ Results for commit 30d6a48. |
dpiparo
approved these changes
Jan 18, 2025
pcanal
requested changes
Jan 18, 2025
guitargeek
commented
Jan 19, 2025
|
@pcanal, thanks for the question! I explained in-line where this is tested. Can you please approve the PR? Even though Danilo approved it, I can't merge it because your change request is blocking the merge. Thanks! |
pcanal
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the code generation also for template histograms with
non-uniform binning, to enable automatic differentiation for template
fits with non-uniform bins.
This was requested both by CMS and ATLAS users, because they use
non-uniform binnings in their Higgs combinations.