[RF] Use fully-qualified name for std::cout in RooFit
#17453
Merged
+1,800
−1,825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to distinguish `std::cout` from the similarly-named RooFit printouts (`coutI`, etc.), because `cout` is a subset of the name of all of those print functions. That made searching through the code for different printout patterns harder than it needed to be.
To be consistent with the rest of the code using `std::cout`. The main benefit is that it's easier to find all printouts with `git grep "std::cout"` now.
Test Results 18 files 18 suites 4d 19h 4m 22s ⏱️ Results for commit 8dfe772. |
pcanal
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes is easier to find occurrences of
std::coutin the code, becuasecoutis also a substring of the names of the RooFit printing functions (likecoutE,coutI, etc.).Like this, we can better distinguish RooFit printing from standard output printing, which helps to work on this GitHub issue: