[tree] properly copy entry list, also queried indices#19036
[tree] properly copy entry list, also queried indices#19036ferdymercury wants to merge 3 commits intoroot-project:masterfrom
Conversation
Test Results 19 files 19 suites 3d 8h 38m 15s ⏱️ Results for commit 87d6950. |
| elist->fLastIndexQueried = fLastIndexQueried; | ||
| elist->fLastIndexReturned = fLastIndexReturned; |
There was a problem hiding this comment.
Most other places, we seem to be using:
| elist->fLastIndexQueried = fLastIndexQueried; | |
| elist->fLastIndexReturned = fLastIndexReturned; | |
| elist->fLastIndexQueried = -1; | |
| elist->fLastIndexReturned = 0; |
why is it different here? (especially since I am not sure whether LastIndex returns is likely to need to be expressed in local entry number)
There was a problem hiding this comment.
I am not sure. It just fixed the issue (empirically)
There was a problem hiding this comment.
I think we do need to understand in order to be able to add a comment with the explanation (so that future maintainer do not spend time 'pondering' the differences). In particular in this case, I don't know whether it is assigning (as opposed to not assignment) or assigning to this particular values that fixes the problem (In particular since the later may or may not work for case of larger chains).
This Pull request:
Changes or fixes:
Fixes #13338
fyi @romainbqt
Checklist: