[cling] Remove hardcoded CLING_OSX_SYSROOT#21393
Draft
vepadulano wants to merge 2 commits intoroot-project:masterfrom
Draft
[cling] Remove hardcoded CLING_OSX_SYSROOT#21393vepadulano wants to merge 2 commits intoroot-project:masterfrom
vepadulano wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results 18 files 18 suites 2d 12h 11m 21s ⏱️ Results for commit 1c41dbe. ♻️ This comment has been updated with latest results. |
95f459f to
f796927
Compare
As is done for rootcling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an upstream of https://github.com/conda-forge/root-feedstock/blob/df86316b299d8214d3181d76c31925696f076d5e/recipe/patches/0011-root-x.xx.xx-osx-remove-hardcoded-sysroot.patch
Opening this one as a draft because I'm not sure of the consequences yet. Let's see what the CI says first.