[TTree] Add compression algorithm test for TFile/TTree #5081

kamahori · 2020-03-02T13:38:49Z

I added unit test TTree.cxx which checks default compression settings used for TFile.

phsft-bot · 2020-03-02T13:38:51Z

Can one of the admins verify this patch?

oshadura · 2020-03-02T13:43:10Z

@pcanal just FYI, it is a GSOC exersize PR :)

tree/tree/test/TTree.cxx

oshadura · 2020-03-02T13:54:58Z

@kamahori Can you add a proper commit message explaining what this code is doing? (it could be helpful https://chris.beams.io/posts/git-commit/)

oshadura · 2020-03-02T13:56:06Z

@phsft-bot build!

phsft-bot · 2020-03-02T13:56:24Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-02T17:57:19Z

Build failed on windows10/cxx14.
See console output.

kamahori · 2020-03-03T14:10:17Z

How can I see the console output?
I cannot create my account on CERN Accelerating science page.

oshadura · 2020-03-03T14:21:03Z

@kamahori Jenkins results of tests are not available for people without CERN account, I am sorry for this. Windows failure is not connected with your test, but is actually infrastructure configuration issue (you need to fork https://github.com/root-project/roottest and it will be gone).

kamahori · 2020-03-03T14:26:54Z

@phsft-bot build

oshadura · 2020-03-03T14:30:05Z

@phsft-bot build just on windows10/cxx14

phsft-bot · 2020-03-03T14:30:15Z

Starting build on windows10/cxx14
How to customize builds

kamahori · 2020-03-03T15:32:25Z

Sorry, I'm not sure how to remove merge message.

oshadura · 2020-03-18T11:49:17Z

@pcanal asked if you can rename file from TTree.cxx to testTTreeCompression.cxx or something similar not to confuse with actual TTree.cxx sources. I will add couple of comments to fix small typos.

phsft-bot · 2020-03-18T11:49:27Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

tree/tree/test/TTree.cxx

phsft-bot · 2020-03-18T12:42:59Z

Build failed on ROOT-fedora27/noimt.
See console output.

Warnings:

phsft-bot · 2020-03-18T12:51:40Z

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Warnings:

phsft-bot · 2020-03-18T12:55:55Z

Build failed on ROOT-ubuntu16/nortcxxmod.
See console output.

Warnings:

phsft-bot · 2020-03-18T12:59:14Z

Build failed on ROOT-fedora30/cxx14.
See console output.

Warnings:

phsft-bot · 2020-03-18T13:23:42Z

Build failed on ROOT-fedora29/python3.
See console output.

Warnings:

Failing tests:

projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_Cpp_IMT_Canvas_notebook

phsft-bot · 2020-03-18T20:19:58Z

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Warnings:

phsft-bot · 2020-03-18T22:41:11Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

oshadura · 2020-03-23T16:51:58Z

@phsft-bot build!

phsft-bot · 2020-03-23T16:52:08Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-23T17:09:34Z

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Warnings:

phsft-bot · 2020-03-23T17:12:41Z

Build failed on ROOT-fedora29/python3.
See console output.

Warnings:

phsft-bot · 2020-03-23T18:03:20Z

Build failed on ROOT-fedora30/cxx14.
See console output.

Warnings:

phsft-bot · 2020-03-23T18:10:51Z

Build failed on ROOT-ubuntu16/nortcxxmod.
See console output.

Warnings:

phsft-bot · 2020-03-23T18:23:18Z

Build failed on ROOT-fedora27/noimt.
See console output.

Warnings:

phsft-bot · 2020-03-23T22:42:27Z

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Warnings:

phsft-bot · 2020-03-23T23:52:44Z

Build failed on mac1014/cxx17.
See console output.

Warnings:

Failing tests:

oshadura · 2020-03-24T08:23:16Z

@kamahori no worries about test failures, it is unrelated to your changes

oshadura · 2020-05-04T11:27:19Z

@pcanal can you please review this PR? and give some suggestions how it could be improved extended?

tree/tree/test/TTreeCompression.cxx

guitargeek

Thanks. I guess the comment requesting additional tests can be addressed in another PR.

Outdated

kamahori requested review from oshadura and pcanal as code owners March 2, 2020 13:38

oshadura previously requested changes Mar 2, 2020

View reviewed changes

tree/tree/test/TTree.cxx Outdated Show resolved Hide resolved

tree/tree/test/TTree.cxx Outdated Show resolved Hide resolved

tree/tree/test/TTree.cxx Outdated Show resolved Hide resolved

oshadura added the new contributor label Mar 2, 2020

oshadura self-assigned this Mar 2, 2020

kamahori changed the title ~~[TTree] added TTree.cxx~~ [TTree] Add TTree.cxx Mar 3, 2020

oshadura changed the title ~~[TTree] Add TTree.cxx~~ [TTree] Add compression algorithm test for TTree Mar 3, 2020

oshadura changed the title ~~[TTree] Add compression algorithm test for TTree~~ [TTree] Add compression algorithm test for TFile/TTree Mar 3, 2020

kamahori force-pushed the master branch from 5d5adba to de43ce1 Compare March 3, 2020 18:54

oshadura reviewed Mar 18, 2020

View reviewed changes

tree/tree/test/TTree.cxx Outdated Show resolved Hide resolved

kamahori force-pushed the master branch from de43ce1 to 29850dd Compare March 18, 2020 17:44

pcanal reviewed May 6, 2020

View reviewed changes

tree/tree/test/TTreeCompression.cxx Outdated Show resolved Hide resolved

pcanal reviewed May 6, 2020

View reviewed changes

tree/tree/test/TTreeCompression.cxx Outdated Show resolved Hide resolved

kamahori force-pushed the master branch from 29850dd to c4f8db5 Compare July 31, 2020 07:01

ferdymercury added in:Testing in:TTree labels Apr 15, 2024

guitargeek force-pushed the master branch from c4f8db5 to a6deed1 Compare May 29, 2025 12:03

guitargeek requested a review from bellenot as a code owner May 29, 2025 12:03

Add googletest testing compression settings of TFile with TTree

e84cf6f

guitargeek force-pushed the master branch from a6deed1 to e84cf6f Compare May 29, 2025 13:52

guitargeek approved these changes May 29, 2025

View reviewed changes

guitargeek requested a review from oshadura May 29, 2025 22:02

guitargeek merged commit 4f570ad into root-project:master May 29, 2025
42 of 47 checks passed

[TTree] Add compression algorithm test for TFile/TTree #5081

[TTree] Add compression algorithm test for TFile/TTree #5081

Uh oh!

Conversation

kamahori commented Mar 2, 2020

Uh oh!

phsft-bot commented Mar 2, 2020

Uh oh!

oshadura commented Mar 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oshadura commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oshadura commented Mar 2, 2020

Uh oh!

phsft-bot commented Mar 2, 2020

Uh oh!

phsft-bot commented Mar 2, 2020

Uh oh!

kamahori commented Mar 3, 2020

Uh oh!

oshadura commented Mar 3, 2020

Uh oh!

kamahori commented Mar 3, 2020

Uh oh!

oshadura commented Mar 3, 2020

Uh oh!

phsft-bot commented Mar 3, 2020

Uh oh!

kamahori commented Mar 3, 2020

Uh oh!

oshadura commented Mar 18, 2020

Uh oh!

phsft-bot commented Mar 18, 2020

Uh oh!

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 18, 2020

Warnings:

Uh oh!

oshadura commented Mar 23, 2020

Uh oh!

phsft-bot commented Mar 23, 2020

Uh oh!

phsft-bot commented Mar 23, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 23, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 23, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 23, 2020

Warnings:

Uh oh!

phsft-bot commented Mar 23, 2020

Warnings:

Uh oh!

oshadura commented Mar 2, 2020 •

edited

Loading