Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Pythonization of RooGlobalFunc Functions in RooFit #8536

Merged
merged 2 commits into from
Jul 1, 2021
Merged

[RF] Pythonization of RooGlobalFunc Functions in RooFit #8536

merged 2 commits into from
Jul 1, 2021

Conversation

harshal0815
Copy link
Contributor

This Pull request:

  • Pythonization of RooGlobalFunc Functions
  • Implementing matplotlib Color/style conventions
  • Pythonization of Tutorial files

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harshal0815 harshal0815 changed the title Roofit gsoc21 4 [RF] Pythonization of RooGlobalFunc Functions Jun 24, 2021
@harshal0815 harshal0815 changed the title [RF] Pythonization of RooGlobalFunc Functions [RF] Pythonization of RooGlobalFunc Functions in RooFit Jun 24, 2021
@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@guitargeek
Copy link
Contributor

Hi @etejedor thank you very much for your suggestions and thanks @Harshalzzzzzzz for addressing them!

As far as I'm concerned, I'm find with this PR now as it is, so let's run the bot tests again.

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@guitargeek guitargeek merged commit 744ce36 into root-project:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek left review comments

@etejedor etejedor etejedor approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

Assignees

@guitargeek guitargeek

Labels
in:Python Interface in:RooFit/RooStats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshal0815 @phsft-bot @guitargeek @etejedor