Leftover Python SyntaxWarnings #346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While version 0.5.1 fixed several SyntaxWarnings associated to the
console logotype, there were still leftover SyntaxWarnings, captured
for instance upon Debian package installation:
Setting up unicycler (0.5.1+dfsg-1) ...
/usr/lib/python3/dist-packages/unicycler/bridge_common.py:43: SyntaxWarning: invalid escape sequence '\l'
"""
/usr/lib/python3/dist-packages/unicycler/bridge_long_read.py:619: SyntaxWarning: invalid escape sequence '\c'
"""
/usr/lib/python3/dist-packages/unicycler/log.py:194: SyntaxWarning: invalid escape sequence '\['
return re.sub('\033\[2m', '', text)
This change sets the raw string prefix for the two affected
docstrings, and also escapes a backaslash in a regex that also
includes a legitimate \033 escape sequence.
These issues were initially reported as [Debian bug #1087157].
[Debian bug #1087157]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1087157
Signed-off-by: Étienne Mollier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While version 0.5.1 fixed several SyntaxWarnings associated to the console logotype, there were still leftover SyntaxWarnings, captured for instance upon Debian package installation:
This change sets the raw string prefix for the two affected docstrings, and also escapes a backaslash in a regex that also includes a legitimate \033 escape sequence.
These issues were initially reported as Debian bug #1087157.