Skip to content

'string/xor.rb' should be named 'string/op_xor.rb' #1

Open

Description

string/xor.rb file should probably be called op_xor.rb instead. That's the going procedure so that facets-live.rb will be able to convert operators to names. Hover someone mentioned it seemed rather redundant to use "op" prefix. Perhaps these methods could just have names without the the prefix?

If there are no significant naming conflicts, then getting rid of the op prefix is a possibility. In the mean time a op_xor.rb alias to xor.rb will do the trick.

Activity

  1. ioquatix commented on Mar 9, 2017

    @ioquatix
    Contributor

    Let's drop the op_ prefix, and make a breaking change in 4.0.0

  2. added this to the 4.0.0 milestone on Mar 9, 2017
  3. ioquatix commented on Mar 9, 2017

    @ioquatix
    Contributor

    Can you explain what you mean by facets-live.rb convert operators to names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions