Skip to content

Conversation

@joshrotenberg
Copy link
Contributor

The guide's serve.md contains out of date command line option docs. This PR brings it inline with the current state of the command.

Fixes #1524.

@ehuss
Copy link
Contributor

ehuss commented May 8, 2021

Thanks, this looks good to me! I notice that this is in Draft state, are you intending to do more changes?

@joshrotenberg
Copy link
Contributor Author

Thanks, this looks good to me! I notice that this is in Draft state, are you intending to do more changes?

I'm trying to decide if adding headings for --hostname and --port makes sense in the same way we have them for --open, etc. i.e.

#### --hostname
....

But I think the ### Server options section covers them. I'll mark it as ready, if you want those added I'm happy to do it.

@joshrotenberg joshrotenberg marked this pull request as ready for review May 8, 2021 21:30
@ehuss
Copy link
Contributor

ehuss commented May 10, 2021

I think it's fine, thanks for the help!

@ehuss ehuss merged commit 331aad1 into rust-lang:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide serve documentation has outdated command line option

2 participants