Conversation
|
|
||
| ## [Unreleased] | ||
| - Remove `zerocopy` dependency (#1579) | ||
| ## [0.9.1] - 2025-04-17 |
There was a problem hiding this comment.
BTW we probably need to add links for release versions (e.g. see the end of the getrandom's changelog), but we can do it in a separate PR.
There was a problem hiding this comment.
Do we? Those don't have to be links (and I don't believe it adds much utility).
There was a problem hiding this comment.
Then we need to remove the square brackets around versions, otherwise we essentially have broken links in our changelog files. IIUC according to the keepachangelog scheme (scroll to the very end of the example file), which we declare to follow, those are intended to be links.
There was a problem hiding this comment.
Markdown is permissive with syntax. The definition of a reference link in GFM is:
A full reference link consists of a link text immediately followed by a link label that matches a link reference definition elsewhere in the document.
I never saw anything suggesting that Markdown should lint against usage of this syntax without a matching link reference definition.
But if you really want to use the keepachangelog scheme then the "unreleased" link should compare against HEAD like this, not use a dead link as in the getrandom changelog (which is something that a link checker should lint against).
P.S. I'm not against doing this; I just can't be bothered (and disagree that using square brackets [like this] is wrong).
There was a problem hiding this comment.
The point is that the square brackets around versions in the keepachangelog scheme are used for references, not to make versions more noticeable.
the "unreleased" link should compare against HEAD
Yes, we should fix it.
CHANGELOG updated.