-
-
Notifications
You must be signed in to change notification settings - Fork 488
Minor tweaks; prepare v0.10.0-rc.9 #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+22
−19
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f643430
Remove obsolete comment
dhardy 27d70b4
Use core::error::Error without feature std
dhardy 7379734
README updates: reprod
dhardy 7a8dc3b
Bump versions to 0.10.0-rc.9
dhardy 2f54a9e
rand_pcg CHANGELOG
dhardy d5f6525
release.yml: also publish rand_pcg
dhardy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is needed. Just publish
rand_pcgmanually for now. For a multi-crate repository you should use a more involved config, e.g. see one from RustCrypto/traits.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That requires a lot of distinct tags, and potentially that they are pushed in the right order.
This is simpler and works fine provided that all crates are released simultaneously under a single tag (good enough in that case, though I also publish a few patches by hand).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the tag order does not matter. The linked config works fine when you push several release tags to one commit simultaneously. The workflow is triggered separately for each pushed tag.
IMO it's a pretty bad restriction and you should use different tags for each crate release. Either way, I do not insist on the suggested approach, though I most certainly would not use your config in RustCrypto repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would if the crates have any inter-depenencies... unless you just re-run the failures?
It is, and is insufficient if all publishing must be done using Trusted Publishing.
On the other hand, RustCrypto/traits has 435 tags. I thought this repo was bad enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, obviously if one crates depends on another inside the repo and we are doing breaking releases, crate releases should be properly sequenced and use different commits. But most repositories contain decoupled crates similarly to the RNGs repo and patch releases are more frequent of a crate than sweeping breaking release cycles.
A significant number of those is caused by the recent unfortunate explosion of RCs (in hindsight we should've been more conservative with those). Since the tags have predictable structure of
crate-name-vX.Y.Zthey are easy to search and it's trivial to find exact commit for a crate release.Either way, the current config is a complete non-starter if crates in repository could be released independently from each other. Arguably, it applies to the
randrepo as well. I doubt you want to release new version ofrand_pcgon a patch release of `rand. and vice versa.