fix(cri): iterate SET contents in iter_raw_values(), not SET TLV#238
Open
sumleo wants to merge 1 commit intorusticata:masterfrom
Open
fix(cri): iterate SET contents in iter_raw_values(), not SET TLV#238sumleo wants to merge 1 commit intorusticata:masterfrom
sumleo wants to merge 1 commit intorusticata:masterfrom
Conversation
iter_raw_values() was iterating over self.value which contains the full SET TLV (tag, length, and content). This caused the iterator to yield the entire SET as a single item rather than iterating over the individual AttributeValue entries inside it. Parse past the SET header first so the iterator correctly yields each value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X509CriAttribute::iter_raw_values()was iterating overself.valuewhich contains the full SET TLV (tag + length + content)AttributeValueentries inside itTest plan
cargo test --all-features