fix(validate): return false from name validator on charset errors#240
Open
sumleo wants to merge 1 commit intorusticata:masterfrom
Open
fix(validate): return false from name validator on charset errors#240sumleo wants to merge 1 commit intorusticata:masterfrom
sumleo wants to merge 1 commit intorusticata:masterfrom
Conversation
X509NameStructureValidator::validate() declared res as immutable true and never updated it, so it always returned true even when invalid charset errors were detected. Make res mutable and set it to false when a non-ASCII character is found in a PrintableString or IA5String attribute value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X509NameStructureValidator::validate()always returnedtrueregardless of validation resultsresvariable was declared as immutabletrueand never updated, even when invalid charset errors were detected and loggedresmutable and setting it tofalsewhen non-ASCII characters are found inPrintableStringorIA5Stringattribute valuesTest plan
cargo test --all-features