This repository was archived by the owner on Jun 19, 2019. It is now read-only.
Windows paths#28
Merged
ryanmcgrath merged 2 commits intoryanmcgrath:masterfrom May 16, 2012
domenic:windows-paths
Merged
Conversation
Fixes Windows inconsistency (#26).
Now they pass on Windows.
Owner
|
Thanks! Bit sick at the moment but trying to wade through pull requests where I can. Will NPM this in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29 by using the
pathmodule instead of manual string manipulation.