Improving tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'm looking into some test failures that I caused right now. |
Gluttton
added a commit
to Gluttton/munkres-cpp
that referenced
this pull request
May 10, 2021
Use a special `const_iterator` type for constant `iterator`. This
change is necessary to avoid iterator conversion errors for
matrices derived from base types that provide `const_iterator` type.
This change is necessary for building tests with GTest v1.10.0.
Test: check building,
$ mkdir build
$ cd build
$ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
$ make full
Issue: saebyn#9.
Signed-off-by: Gluttton <[email protected]>
Gluttton
added a commit
to Gluttton/munkres-cpp
that referenced
this pull request
May 10, 2021
Test: check building of tests,
$ mkdir build
$ cd build
$ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
$ make tests
Issue: saebyn#9.
Signed-off-by: Gluttton <[email protected]>
Gluttton
added a commit
to Gluttton/munkres-cpp
that referenced
this pull request
May 10, 2021
Use a special `const_iterator` type for constant `iterator`. This
change is necessary to avoid iterator conversion errors for
matrices derived from base types that provide `const_iterator` type.
This change is necessary for building tests with GTest v1.10.0.
Test: check building,
$ mkdir build
$ cd build
$ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
$ make full
Issue: saebyn#9.
Signed-off-by: Gluttton <[email protected]>
Gluttton
added a commit
to Gluttton/munkres-cpp
that referenced
this pull request
May 10, 2021
Test: check building of tests,
$ mkdir build
$ cd build
$ cmake -DMUNKRESCPP_DEVEL_MODE=ON ..
$ make tests
Issue: saebyn#9.
Signed-off-by: Gluttton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving tests (adding test cases, formatting source code, enhance output).