Improve Project Cleaning

[allentiak]

In order to initialize properly, the server needs the Job IG resource files in specific locations (see below).
Since those files are prepped only if they did not exist before, we need do delete them every time we make a make clean.

Context:

• the Job IG resource files are generated by make -C job-ig build, and saved in the folder job-ig/fsh-generated/resources.

• then, when clojure -X:deps prep is executed, the resource files are copied to the individual resources
  path's (e.g.
  modules/job-re-index/resources/blaze/job/re_index/CodeSystem-ReIndexJobOutput.json) via build/copy-profiles. But this only happens if the folders don't already exist. See
  https://clojure.org/reference/deps_edn#prep_lib

If the server cannot find the files in their right locations, it will fail to initialize with the following error:

2024-11-11T16:30:08.301Z d2e461cd82fc main ERROR [blaze.core:21] - Error
while initializing Blaze.

    Error on key :blaze/admin-api when building system

    Cause:

    Config:
      ADMIN_INDEX_DB_DIR = /app/data/admin-index,
      ADMIN_TRANSACTION_DB_DIR = /app/data/admin-transaction,
      HOME = /,
      HOSTNAME = d2e461cd82fc,
      INDEX_DB_DIR = /app/data/index,
      JAVA_HOME = /opt/java/openjdk,
      JAVA_VERSION = jdk-21.0.5+11,
      JRE_CACERTS_PATH = /opt/java/openjdk/lib/security/cacerts,
      LANG = en_US.UTF-8,
      LANGUAGE = en_US:en,
      LC_ALL = en_US.UTF-8,
      LD_PRELOAD = libjemalloc.so.2,
PATH =
/opt/java/openjdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin,
      PWD = /app,
      RESOURCE_DB_DIR = /app/data/resource,
      SHLVL = 0,
      STORAGE = standalone,
      TRANSACTION_DB_DIR = /app/data/transaction

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (8dc3378) to head (f07384c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2187   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         330      330           
  Lines       20249    20249           
  Branches      487      486    -1     
=======================================
  Hits        19236    19236           
  Misses        527      527           
  Partials      486      486           

[alexanderkiel]

Deleting resources can't be done always.

[alexanderkiel]

Thanks, so root of the problem was that make clean did not work properly and so building Blaze on a non fresh repo checkout will not work. That's also the reason, the issue did not surface on the CI pipeline, because it always uses fest checkouts.