Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Resource Handle Deleted Function #2211

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Nov 22, 2024

The new blaze.db.api/deleted? function makes it more easy to detect whether a resource handle is deleted. Before that we had to test if the :op of the handle equals :deleted.

Previously optimize got a node, but later we switched to call optimize
with the same db as will be used in eval.
The new blaze.db.api/deleted? function makes it more easy to detect
whether a resource handle is deleted. Before that we had to test if the
:op of the handle equals :deleted.
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (187aaba) to head (ee1eb83).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         330      330           
  Lines       20249    20252    +3     
  Branches      483      482    -1     
=======================================
+ Hits        19227    19231    +4     
  Misses        539      539           
+ Partials      483      482    -1     

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@alexanderkiel alexanderkiel added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 8ff3e98 Nov 24, 2024
133 checks passed
@alexanderkiel alexanderkiel deleted the resource-handle-delete branch November 24, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant