-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Response Status Code for Failing XML Emits #2217
Conversation
4612f6c
to
aa5fcfe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
==========================================
- Coverage 94.96% 94.96% -0.01%
==========================================
Files 330 330
Lines 20252 20258 +6
Branches 483 482 -1
==========================================
+ Hits 19232 19237 +5
- Misses 538 539 +1
Partials 482 482 |
aa5fcfe
to
d655d63
Compare
Update both the request body and status in case of errors, not just the body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution is functionally perfect. It's only the naming I have to criticise.
d655d63
to
4f0c0f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you please could change the commit message into something like this:
Fix Response Status Code for Failing XML Emits
In case the generation of XML for responses failed, an OperationOutcome was
already produced, but the status code was kept at 200. However in such a
case that the server was unable to generate the XML output, the status
code has to be 500.
I would be perfect.
In case that the generation of XML for responses failed, an OperationOutcome was already produced - but the status code was kept at 200. This was incorrect: in such a case that the server is unable to generate the XML output, the status code should be changed to 500.
4f0c0f6
to
bd5739f
Compare
Thanks for the suggestion. |
In case that the generation of XML for responses failed, an OperationOutcome was already produced - but the status code was kept at 200. This was incorrect: in such a case that the server is unable to generate the XML output, the status code should be changed to 500.