Skip to content

Lidar Scene Transforms #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
patrick-scale wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Lidar Scene Transforms #265

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c284792
adding some files
patrick-scale Mar 24, 2022
9b31d95
Nucleus 3D ingest base level transforms
patrick-scale Apr 5, 2022
84e1eec
merging w/ master
patrick-scale Apr 5, 2022
5f155ec
updating testing file
patrick-scale Apr 5, 2022
19c57c6
cleaning
patrick-scale Apr 5, 2022
479c342
Sensor Fusion base transforms
patrick-scale Apr 5, 2022
96cacb9
Sensor Fusion Basic Objects
patrick-scale Apr 5, 2022
4095a57
Merge branch '3D_IngestBranch' of github.com:scaleapi/nucleus-python-…
patrick-scale Apr 5, 2022
3cea689
cleaning2
patrick-scale Apr 5, 2022
26c3578
adding utils
patrick-scale Apr 5, 2022
f3c2fa7
Update nucleus/sensorfusion.py
patrick-scale Apr 8, 2022
9d9e32d
Update nucleus/sensorfusion.py
patrick-scale Apr 8, 2022
5021ce6
Update nucleus/sensorfusion.py
patrick-scale Apr 8, 2022
4cca2e6
Update nucleus/transform.py
patrick-scale Apr 8, 2022
f7c0d39
feedback updates
patrick-scale Apr 8, 2022
203ec13
exception updates and name changes
patrick-scale Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nucleus/transform.py 
Co-authored-by: Sasha Harrison <[email protected]>
  • Loading branch information
@patrick-scale @sasha-scale
patrick-scale and sasha-scale authored Apr 8, 2022
commit 4cca2e6e68c22cfd97067cb39b4d88990f53a6f7
2 changes: 1 addition & 1 deletion nucleus/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
class Transform:
Copy link
Contributor

@sasha-scale sasha-scale Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the user can supply a lot of different values in the constructor. Do all class methods apply to all possible types of values? if not, you may want to separate into different class types (maybe use inheritance?)

"""Transform object represent a rigid transformation matrix (rotation and translation).

Transform is a 4x4 matrix, although it could be instance using (16,1), (3,4), (3,3) or (3,1) matrixes.
Transform is a 4x4 matrix, although it could be instance using (16,1), (3,4), (3,3) or (3,1) matrices.
**Note**: not all the methods from Transform will work using scaled/small matrixes

.. highlight:: python
Expand Down