-
Notifications
You must be signed in to change notification settings - Fork 11
Add metadata support for scene categories #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
test failures unrelated :sadge: |
|
trying to fix failures here! #347 |
drakejwong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🙌 but we'll probably need to rebase once #347 lands for CI fixes
might also consider adding some e2e tests / filling a followup ticket to add
|
@drakejwong Def, here's the ticket for test improvements: https://app.shortcut.com/scaleai/story/549800 |
82ae518 to
f95f1d5
Compare
|
@drakejwong after yesterday evening's rebase tests still fail 🤔 cc @jihan-yin bc failures are coming from |
|
@jihan-yin looks like the even though the backend changes should have made it into today's deploy :( i'll look into the |
|
@anthonykrivonos
|
|
@drakejwong Ah gotcha, welp thanks for the merge 🙌 |

Added
metadatatoSceneCategoryAnnotationandSceneCategoryPrediction, as well asconfidencetoSceneCategoryPrediction.https://app.shortcut.com/scaleai/story/546247/nucleus-metadata-support-for-scene-categorization