Skip to content

Conversation

@anthonykrivonos
Copy link
Contributor

@anthonykrivonos anthonykrivonos commented Aug 15, 2022

Added metadata to SceneCategoryAnnotation and SceneCategoryPrediction, as well as confidence to SceneCategoryPrediction.

https://app.shortcut.com/scaleai/story/546247/nucleus-metadata-support-for-scene-categorization

@anthonykrivonos
Copy link
Contributor Author

test failures unrelated :sadge:

@drakejwong
Copy link
Contributor

trying to fix failures here! #347

Copy link
Contributor

@drakejwong drakejwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙌 but we'll probably need to rebase once #347 lands for CI fixes

might also consider adding some e2e tests / filling a followup ticket to add

@anthonykrivonos
Copy link
Contributor Author

@drakejwong Def, here's the ticket for test improvements: https://app.shortcut.com/scaleai/story/549800

@anthonykrivonos anthonykrivonos enabled auto-merge (squash) August 16, 2022 14:38
@anthonykrivonos
Copy link
Contributor Author

@drakejwong after yesterday evening's rebase tests still fail 🤔 cc @jihan-yin bc failures are coming from test_update_autotag and test_slice_create_and_prediction_export

@drakejwong
Copy link
Contributor

@jihan-yin looks like the update_autotag test is still failing with

{"status_code":404,"error":"Nucleus Autotag with id tag_c8jwr0rpy1w00e134an0 not found! When reporting an issue add the request_id:'dea8f877-9bef-9631-8a35-2ce65b5c464e'"}

even though the backend changes should have made it into today's deploy :(

i'll look into the export_predictions failure, i think there might've been a backend regression since it's now failing consistently (but wasn't until recently)

@anthonykrivonos
Copy link
Contributor Author

@drakejwong
6qrp6d

@anthonykrivonos anthonykrivonos merged commit efd05db into master Aug 22, 2022
@anthonykrivonos anthonykrivonos deleted the kriv-scene-categ-meta branch August 22, 2022 19:08
@drakejwong
Copy link
Contributor

@anthonykrivonos test_segmentation_pred_upload is still flaky so i just reran CI and it passed — have a ticket to investigate

test_slice_create_and_prediction_export and test_update_autotag were actually broken though and have now been fixed! appreciate your patience on these good sir 🙏

@anthonykrivonos
Copy link
Contributor Author

@drakejwong Ah gotcha, welp thanks for the merge 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants