Skip to content

fix circleci race conditions #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drakejwong merged 1 commit into from
Aug 26, 2022
Merged

fix circleci race conditions #350

drakejwong merged 1 commit into from
Aug 26, 2022

Conversation

@drakejwong
Copy link
Contributor

@drakejwong drakejwong commented Aug 26, 2022

Loosen test asserts that are failing on race conditions

@drakejwong drakejwong requested a review from shiftsayan August 26, 2022 17:07
shiftsayan
shiftsayan approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@shiftsayan shiftsayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@drakejwong drakejwong merged commit 173552a into master Aug 26, 2022
@drakejwong drakejwong deleted the drake-fix-tests branch August 26, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shiftsayan shiftsayan shiftsayan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drakejwong @shiftsayan