Fix model metrics test #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatli
requested changes
Sep 13, 2022
Contributor
gatli
left a comment
There was a problem hiding this comment.
This is being used as an integration test for the model_run_commit job so this is letting us know when the pipeline is broken. I'd rather we wait on the job for it to finish.
gatli
approved these changes
Sep 13, 2022
Contributor
gatli
left a comment
There was a problem hiding this comment.
Since apparently we can't currently track the state of the evaluation job we can merge this. @shiftsayan is going to add a task to add AsyncJob tracking to the calculate_evaluation_metrics such that we can properly test that it runs to end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model metrics are not being used anywhere in the test.
This call is causing errored jobs on the backend because by the time the async job starts the test is completed and dataset yielded in the test fixture is deleted from the database.