Skip to content

Conversation

@seanshi-scale
Copy link
Contributor

@seanshi-scale seanshi-scale commented Sep 23, 2022

If show_image=True, pops up a new window with the image. Also just returns the image with the boxes/lines/polygons drawn on top.

If we want we can use matplotlib.pyplot.imshow to display the image, although it looks uglier inside of the jupyter notebook (and I'd assume uglier as well from a python script)

Jupyter nb: vvv

image

Previous version: vvv
image

@seanshi-scale seanshi-scale self-assigned this Sep 23, 2022
# From scaleapi/server/src/lib/select/api/types.ts
_TOP_LEVEL_REQUIRED_KEYS = {"geometry", "type"}
_TOP_LEVEL_OPTIONAL_KEYS = {"label", "confidence", "classPdf", "metadata"}
# TODO idk which ones are right for nucleus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I'm not sure which keys make sense to include, I've semi-arbitrarily included these 4 for now

@seanshi-scale seanshi-scale marked this pull request as ready for review September 23, 2022 01:56
@seanshi-scale seanshi-scale requested a review from a team September 23, 2022 01:56
class BoxAnnotationModel(BaseModel, extra=Extra.forbid):
geometry: BoxGeometryModel
type: str
label: Optional[str] = None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO these keys aren't complete, I'm not entirely sure which ones it makes sense to include

Copy link
Contributor

@syandroo syandroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazin

@seanshi-scale seanshi-scale merged commit 185a060 into master Sep 26, 2022
@seanshi-scale seanshi-scale deleted the seanshi/local-nucleuslaunch-bundle-testing branch September 26, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants